Band 28 not appearing in mmcli output

[Nick B]

Hey!

Tested and working for me, here is the patch.  Next I need to get it into mmcli’s output.


diff --git a/src/libqmi-glib/qmi-flags64-dms.h b/src/libqmi-glib/qmi-flags64-dms.h
index 240d26c..f9dbe88 100644
--- a/src/libqmi-glib/qmi-flags64-dms.h
+++ b/src/libqmi-glib/qmi-flags64-dms.h
@@ -193,13 +193,7 @@ typedef enum {
     /* Bit 21-22 reserved */
     QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_24 = 1 << 23,
     QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_25 = 1 << 24,
-    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_26 = 1 << 25,
-    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_27 = 1 << 26,
-    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_28 = 1 << 27,
-    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_29 = 1 << 28,
-    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_30 = 1 << 29,
-    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_31 = 1 << 30,
-    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_32 = 1 << 31,   
+    /* Bit 25-31 reserved */
     QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_33 = ((guint64) 1) << 32,
     QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_34 = ((guint64) 1) << 33,
     QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_35 = ((guint64) 1) << 34,



And here is some sample output 
Before patch:
root at openwrt:(unknown)# qmicli -d /dev/cdc-wdm0 -p --dms-get-band-capabilities
[/dev/cdc-wdm0] Device band capabilities retrieved:
	Bands: 'wcdma-2100, wcdma-850-us, wcdma-800, wcdma-900, wcdma-1700-japan, wcdma-850-japan'
	LTE bands: '1, 3, 5, 7, 8, 18, 19, 21, 38, 39, 40, 41'

With patch:
root at openwrt:~# qmicli -d /dev/cdc-wdm0 -p --dms-get-band-capabilities
[/dev/cdc-wdm0] Device band capabilities retrieved:
	Bands: 'wcdma-2100, wcdma-850-us, wcdma-800, wcdma-900, wcdma-1700-japan, wcdma-850-japan'
	LTE bands: '1, 3, 5, 7, 8, 18, 19, 21, 28, 38, 39, 40, 41'


Best,
Nicholas

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20181107/5c01ea22/attachment.html>