Band 28 not appearing in mmcli output

[Aleksander Morgado]

Hey!

> > > I got it installed, but it is still missing band 28 in the mmcli and qmicli output.  It is a MC7430 in QMI mode.  Any special requirements?
> > >
> > >
> > >   Bands    |      supported: 'utran-1, utran-6, utran-5, utran-8, utran-9, eutran-1, eutran-3, eutran-5, eutran-7, eutran-8, eutran-18, eutran-19, eutran-21, eutran-38, eutran-39, eutran-40, eutran-41, utran-19'
> > >            |        current: 'unknown'
> > >   -------------------------
> > >
> > >
> > > # qmicli -d /dev/cdc-wdm0 -p --dms-get-band-capabilities
> > > [/dev/cdc-wdm0] Device band capabilities retrieved:
> > > Bands: 'wcdma-2100, wcdma-850-us, wcdma-800, wcdma-900, wcdma-1700-japan, wcdma-850-japan'
> > > LTE bands: '1, 3, 5, 7, 8, 18, 19, 21, 38, 39, 40, 41'
> > >
> >
> > Well, looks like the modem doesn't report the "Extended LTE Band
> > Capability" TLV in the Get Band Capabilities response; probably a
> > limitation of the firmware. Is this using the latest firmware version?
> >
>
> Hi Aleksander,
>
> the "Extended LTE Band Capability" TLV only seems to be used by devices
> which use LTE bands > 64. For other devices flags which are marked as
> "reserved" in the latest/last(?) GobiAPI_2013-07-31-1347.tar.gz are used
> which explains why some LTE bands are missing in mmcli/qmicli output for
> devices like the MC7430:
>
>   Sierra Wireless EM7565:
>   DMSGetBandCapabilities 3000
>   +OK DMSGetBandCapabilities 020400000000000108000000c00f00000610100800df190eba00a7000011080000000000000000001232001800010002000300040005000700080009000c000d001200130014001a001c001d001e00200029002a002b002e0030004200
>   Sierra Wireless MC7455:
>   DMSGetBandCapabilities 3000
>   +OK DMSGetBandCapabilities 020400000000001108000000000000000000100800df180833000100000108000000c00700000200
>   Sierra Wireless MC7430:
>   DMSGetBandCapabilities 3000
>   +OK DMSGetBandCapabilities 020400000000001108000000000000000000100800d5001608e00100000108000000400c00000610
>   Quectel BG96:
>   DMSGetBandCapabilities 3000
>   +OK DMSGetBandCapabilities 0204000000000001080080032800000000001008009f180f0a40000000
>
> This also applies to NASGetSystemSelectionPref/NASSetSystemSelectionPref.
>

Ohhh, so we just need to add the proper enum entries instead of
flagging them as "reserved" e.g. here:

    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_24 = 1 << 23,
    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_25 = 1 << 24,
    /* Bit 25-31 reserved */
    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_33 = ((guint64) 1) << 32,
    QMI_DMS_LTE_BAND_CAPABILITY_EUTRAN_34 = ((guint64) 1) << 33,

That's an easy fix, anyone up to doing this easy one? :)

And so we should also probably update the QmiNasActiveBand entry
accordingly as well.

-- 
Aleksander
https://aleksander.es