Crashes in g_hash_table_iter_next call

Aleksander Morgado aleksander at aleksander.es
Wed Nov 28 11:03:37 UTC 2018


Hey,

>
> > Have you not found the issue with MM 1.8? Or just not tried?
>
>
> We have not tried with MM 1.8 (we have not a method to reproduce these crashes).
>
> Do you think that "self->priv->ports" value should be checked before using it in all methods of mm-base-modem.c ? Or just destroyed and set to NULL in finalize ?
>

If we take this as a race condition, probably just modifying
mm_base_modem_find_ports() is enough. What I was referring to was that
it is probably easier to reproduce this problem if there are dangling
modem references around (I believe I've fixed a couple of these in
1.8.x). But in theory without the dangling references it may still
happen if very unlucky.

I've pushed a fix to git master to handle this:
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/commit/7510b3355d7c1a670ab1eff373ef04bc5a8ad282

-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list