Crashes in g_hash_table_iter_next call

[Sebastien Fabre]

Thanks Aleksander


Sebastien Fabre
Embedded Software Engineer
[http://www.sigfox.com/static/media/signature_sigfox_logo_nov16.png]<http://www.sigfox.com>     Bâtiment E-volution - 425, rue Jean Rostand
31670 Labège, France
sebastien.fabre at sigfox.com<mailto:sebastien.fabre at sigfox.com>
sigfox.com<http://www.sigfox.com>
[http://www.sigfox.com/static/media/T.png] <https://twitter.com/sigfox> [http://www.sigfox.com/static/media/F.png]  <http://www.facebook.com/sigfox> [http://www.sigfox.com/static/media/L.png]  <http://www.linkedin.com/company/2731408> [http://www.sigfox.com/static/media/Y.png]  <https://www.youtube.com/sigfox>



________________________________
De : Aleksander Morgado <aleksander at aleksander.es>
Envoyé : mercredi 28 novembre 2018 12:03:37
À : Sebastien Fabre
Cc : ModemManager (development)
Objet : Re: Crashes in g_hash_table_iter_next call

Hey,

>
> > Have you not found the issue with MM 1.8? Or just not tried?
>
>
> We have not tried with MM 1.8 (we have not a method to reproduce these crashes).
>
> Do you think that "self->priv->ports" value should be checked before using it in all methods of mm-base-modem.c ? Or just destroyed and set to NULL in finalize ?
>

If we take this as a race condition, probably just modifying
mm_base_modem_find_ports() is enough. What I was referring to was that
it is probably easier to reproduce this problem if there are dangling
modem references around (I believe I've fixed a couple of these in
1.8.x). But in theory without the dangling references it may still
happen if very unlucky.

I've pushed a fix to git master to handle this:
https://gitlab.freedesktop.org/mobile-broadband/ModemManager/commit/7510b3355d7c1a670ab1eff373ef04bc5a8ad282

--
Aleksander
https://aleksander.es
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20181128/2ecf4b13/attachment-0001.html>