[review] Fix sending/storing SMS messages when other AT commands get in the way

Aleksander Morgado aleksander at aleksander.es
Sun May 19 07:42:35 UTC 2019

Hey Dan & all,

The original fix I had for this issue was to always add raw commands
to the head of the queue inside the serial port:

The new fix I have for this issue is to setup a new queue of
operations at modem object level, so that no AT command/sequence can
be run if another AT command/sequence is running, and then I ported
the SMS send/store operations to be run as a sequence instead of
independent commands:

I'm not sure, but looking at both MRs as if I hadn't written them
myself, I think that the original fix in MR#103 is much simpler, the
second one introduces another level of complexity that not sure if
it's needed.

What do you think?


More information about the ModemManager-devel mailing list