modemmanager/qmicli openwrt feed update

[Amol Lad]

Hi Nick,

When do you think the merge will be done?

Amol

From: Nick B <nickberry17 at icloud.com>
Sent: Monday, 9 September 2019 6:02 PM
To: Aleksander Morgado <aleksander at aleksander.es>
Cc: Amol Lad <Amol.Lad at 4rf.com>; ModemManager (development) <modemmanager-devel at lists.freedesktop.org>
Subject: Re: modemmanager/qmicli openwrt feed update

Hey everyone!

The final missing piece before a merge might be making sure the scripts pass Shellcheck, which, if you don’t know, ensures the script is POSIX compliant.  I have started on that work in my Shellcheck branch linked below.  If anyone would like to test, I think the modemmanager.common file is done, but modemmanager.proto might be ready tomorrow.  I could only test it on OpenWrt, which uses the Almquist shell.  Tested by stopping/starting MM, rebooting, debug mode, and reading the logread output.

Code
https://github.com/nickberry17/packages-1/tree/shellcheck/net/modemmanager/files


A couple of questions:

Does this variable need to be used by another file?
In modemmanager.common line 14:
MODEMMANAGER_PID_FILE="${MODEMMANAGER_RUNDIR}/modemmanager.pid"
^-- SC2034: MODEMMANAGER_PID_FILE appears unused. Verify it or export it.

Is the expected behaviour to only apply permissions on the deepest directory?  25-modemmanager-tty has the same.
In 25-modemmanager-net line 12:
mkdir -m 0755 -p "${MODEMMANAGER_RUNDIR}"
      ^-- SC2174: When used with -p, -m only applies to the deepest directory.


Best,
Nick
________________________________
The information in this email communication (inclusive of attachments) is confidential to 4RF Limited and the intended recipient(s). If you are not the intended recipient(s), please note that any use, disclosure, distribution or copying of this information or any part thereof is strictly prohibited and that the author accepts no liability for the consequences of any action taken on the basis of the information provided. If you have received this email in error, please notify the sender immediately by return email and then delete all instances of this email from your system. 4RF Limited will not accept responsibility for any consequences associated with the use of this email (including, but not limited to, damages sustained as a result of any viruses and/or any action or lack of action taken in reliance on it).
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/modemmanager-devel/attachments/20190923/d37cd060/attachment.html>