modemmanager/qmicli openwrt feed update

Aleksander Morgado aleksander at aleksander.es
Mon Sep 9 13:37:07 UTC 2019


> Does this variable need to be used by another file?
> In modemmanager.common line 14:
> MODEMMANAGER_PID_FILE="${MODEMMANAGER_RUNDIR}/modemmanager.pid"
> ^-- SC2034: MODEMMANAGER_PID_FILE appears unused. Verify it or export it.
>

Don't think it's used anywhere else.

> Is the expected behaviour to only apply permissions on the deepest directory?  25-modemmanager-tty has the same.
> In 25-modemmanager-net line 12:
> mkdir -m 0755 -p "${MODEMMANAGER_RUNDIR}"
>       ^-- SC2174: When used with -p, -m only applies to the deepest directory.
>

I think this should be good, but is there any way to ignore this check
or improve it somehow?

-- 
Aleksander
https://aleksander.es


More information about the ModemManager-devel mailing list