[Nice] unexported symbols in libnice used in test code

[Youness Alaoui]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

Sorry for the late response.. Well about this issue, I see a few solutions :
1 - do not build the unit tests since they're totally unnecessary (on
windows, we don't build them either)
2 - build the unit tests while exporting all the symbols so they would
build and you can do 'make check' to make sure everything works.. But
when you build the final library you would be using in your application,
then have only the symbols in libnice.sym exported!

The thing is that the unit test code is using non public API to test
very small specific parts of the code, which is why it's using
non-exported symbols from the public API.

by the way, as far as I know, the test code should link directly with
the .a not with the .so, so it wouldn't matter what functions are
exported in the .so, no ?

I hope that helps,

Youness.

purushottam.naik at nokia.com wrote:
> Hi,
>  
> I have been trying to port libnice to symbian. I could build entire
> libnice code. But while building the test code, I am getting some linker
> errors.
> The errors I am getting because the test code is trying to use apis in
> libnice.dll which are not exported. My question is should these symbols
> are also be exported?
> For example, nice_candidate_ice_priority is not an exported function,
> but test-priority.c is using this function.  So, should I export
> nice_candidate_ice_priority as well? I am assuming that the only symbols
> that supposed to be exported are the ones in libnice.sym.
>  
> In symbian, the functions are exported only when they are marked as
> EXPORT_C in their declarations. But in nix functions are exported by
> default unless they are marked as static .
> As of now I have exported only symbols that are present in libnice.sym..
> Can somebody clarify if I should be exporting these symbols used in test
> code as well?
>  
> Regards
> Purushottam
>  
>  
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> Nice mailing list
> Nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkqUMxQACgkQqvxLNLvrsxzSIQCggVv5BKdyCX5zLMHgn3noqxk9
a+cAmwWfW882UPJvsMWcwnvbhireDLuY
=jzQ7
-----END PGP SIGNATURE-----