[Nice] R: R: R: R: R: R: patches for gsocket support and gtk-doc missing

Tue Mar 13 01:29:46 PDT 2012

The "only" advantage is to allow msys/mingw users to compile libnice without installing gtk-doc (that is quite a real pain..)
Anyway I understand your point of view..
Regards,
Filippo

-----Messaggio originale-----
Da: nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freedesktop.org [mailto:nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freedesktop.org] Per conto di Youness Alaoui
Inviato: lunedì 12 marzo 2012 19:42
A: nice at lists.freedesktop.org
Oggetto: Re: [Nice] R: R: R: R: R: patches for gsocket support and gtk-doc missing

Yes || true would fix it for your case, but it wouldn't help in case an actual error happens for someone who has gtk-doc installed.
Also, this is much more complicated than it seems, first, it's not just about the gtk-doc.make, it's also about the m4 needed by the configure script, if --enable-gtk-doc option was given, it would probably give an error because the configure macro wasn't properly substituted.
In order to fix this properly, a lot more changes would be needed, and honestly, I see absolutely no advantages to doing that. This is completely useless for the users because they don't need gtk-doc to be installed since the Makefile.in and configure scripts are already generated in the tarballs, and the doc is pre-generated and also included in the tarballs. So this is purely for developers using the git version, and I believe developers should simply have gtk-doc installed.
For those reasons, I'm sorry but I will reject that patch, I don't see any advantages to it, and it will just be an ugly hack to work around installing a needed tool.
As for gtk-doc.make, on linux it's a symlink to /usr/share/gtk-doc/data/gtk-doc.make, and it's also included in any release tarball, so you could just copy it from there if you wanted.

Thanks,
Youness.

On 03/12/2012 06:05 AM, Della Betta Filippo wrote:
> You're right.
> I generally use autoreconf -fi instead of ./autogen.sh, that's why I 
> missed the error Probably something like gtkdocize || true should do 
> the trick..
> What do you think ?
> Regards,
> Filippo
> 
> 
> -----Messaggio originale-----
> Da: 
> nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freedesktop.org 
> [mailto:nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freedes
> ktop.org] Per conto di Youness Alaoui
> Inviato: venerdì 9 marzo 2012 22:57
> A: nice at lists.freedesktop.org
> Oggetto: Re: [Nice] R: R: R: R: patches for gsocket support and 
> gtk-doc missing
> 
> Humm.. you're right the include happens during the autogen, not during make, so my suggestion makes no sense...
> I'll have to think about it. especially since it's not useful at all for common users as the configure/makefile.in would be generated in a release tarball, so this would only be useful for git users.. and those should definitely have gtk-doc installed.
> Also, your patch does a touch gtk-doc.make but leaves the gtkdocize || exit 1..
> wouldn't the 'exit' there defeat the purpose ?
> 
> 
> On 03/08/2012 03:35 AM, Della Betta Filippo wrote:
>> I also thought that was good, but it didn't work..
>> The problem is that the include statement is always "executed" even 
>> in the case of conditional before
>>
>> If ENABLE_GTK_DOC
>> Include ...gtk-doc.make
>> endif
>>
>> in this case, if you look at Makefile generated, you can see that the 
>> file is included and commented, and therefore it complains if no gtk-doc.make is present As you can imagine I'm not an expert of autotools, and this explains my patch...
>> Regards,
>> Filippo
>>
>> -----Messaggio originale-----
>> Da: Youness Alaoui [mailto:youness.alaoui at collabora.co.uk]
>> Inviato: mercoledì 7 marzo 2012 20:38
>> A: Della Betta Filippo
>> Cc: 'nice at lists.freedesktop.org'
>> Oggetto: Re: R: [Nice] R: R: patches for gsocket support and gtk-doc 
>> missing
>>
>> I would think the better/simplest solution is :
>> if ENABLE_GTK_DOC
>> SUBDIRS += docs
>> endif
>>
>> in the Makefile.am in the top build dir.
>>
>>
>> On 03/07/2012 07:53 AM, Della Betta Filippo wrote:
>>> Here is a patch that should fix this issue (I hope so at least:) ) I 
>>> created a blank file named gtk-doc.make in autogen.sh If gtkdocize 
>>> exists, the empty gtk-doc.make is replaced from the output of 
>>> gtkdocize, otherwise a blank gtk-doc.make is harmless for Makefile.am What do you think ?
>>> Regards,
>>> Filippo
>>>
>>> -----Messaggio originale-----
>>> Da: 
>>> nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freedesktop.o
>>> nice-bounces+r
>>> nice-bounces+g
>>> [mailto:nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freed
>>> e s ktop.org] Per conto di Della Betta Filippo
>>> Inviato: mercoledì 7 marzo 2012 10:07
>>> A: 'Youness Alaoui'; 'nice at lists.freedesktop.org'
>>> Oggetto: [Nice] R: R: patches for gsocket support and gtk-doc 
>>> missing
>>>
>>> You're right.
>>> I have to think to another method to exclude that include..
>>> Regards,
>>> Filippo
>>>
>>> -----Messaggio originale-----
>>> Da: 
>>> nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freedesktop.o
>>> nice-bounces+r
>>> nice-bounces+g
>>> [mailto:nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freed
>>> e s ktop.org] Per conto di Youness Alaoui
>>> Inviato: martedì 6 marzo 2012 21:50
>>> A: nice at lists.freedesktop.org
>>> Oggetto: Re: [Nice] R: patches for gsocket support and gtk-doc 
>>> missing
>>>
>>> Yeah, that's what I thought, but I think the '-' before the include only works for the Makefile, but gtk-doc.make is not a Makefile file, it's a Makefile.am file...
>>> What happens is that I did a ./autogen.sh, then ./configure, then look at the Makefile that gets generates by automake, it will have the "-include gtk-doc.make" in it, and when you run make, it will complain that the file is missing a separator, etc...
> 
>>> The problem is that the gtk-doc.make must be parsed by automake and must be used to generate the Makefile, but with your patch, it wasn't included by the Makefile.am, and automake ignored it and it would then be included by the Makefile itself when you type 'make', which makes it crash because it's not a proper makefile file format.
>>>
>>> On 03/06/2012 03:53 AM, Della Betta Filippo wrote:
>>>> The '-' before the include means that if you don't find the file, the process goes on and doesn't stop with an error.
>>>> This happens when you don't call gtkdocize (since you don't have 
>>>> gtk-doc installed) before autoreconf -fi The patch must be applied to Makefile.am since Makefile is generated from that by automake.
>>>> Which error did you face ?
>>>> Regards,
>>>> Filippo
>>>>
>>>> -----Messaggio originale-----
>>>> Da: 
>>>> nice-bounces+filippo.dellabetta=telecomitalia.it at lists.freedesktop.
>>>> nice-bounces+o
>>>> nice-bounces+r
>>>> nice-bounces+g
>>>> [mailto:nice-bounces+filippo.dellabetta=telecomitalia.it at lists.free
>>>> d e s ktop.org] Per conto di Youness Alaoui
>>>> Inviato: martedì 6 marzo 2012 02:50
>>>> A: nice at lists.freedesktop.org
>>>> Oggetto: Re: [Nice] patches for gsocket support and gtk-doc missing
>>>>
>>>> I merged both but I had to modify the second one, this chunk broke the makefile though :
>>>>
>>>> -include $(top_srcdir)/gtk-doc.make
>>>> +-include $(top_srcdir)/gtk-doc.make
>>>>
>>>> I don't know why you added that '-' in front of the include. It made it include the gtk-doc.make file from the Makefile not from the Makefile.am, which caused it to error out.
>>>>
>>>> On 03/05/2012 06:36 AM, Della Betta Filippo wrote:
>>>>> Hi,
>>>>>
>>>>> Attached you can find patches for
>>>>>
>>>>> 1)      Support for msys/mingw and Visual Studio for gsocket (added gio
>>>>> dependency), after Livio's patches
>>>>>
>>>>> 2)      Support for msys/mingw when gtk-doc is not installed
>>>>>
>>>>> Regards,
>>>>>
>>>>> Filippo Della Betta
>>>>>
>>>>>
>>>>>
>>>>> Questo messaggio e i suoi allegati sono indirizzati esclusivamente 
>>>>> alle persone indicate. La diffusione, copia o qualsiasi altra 
>>>>> azione derivante dalla conoscenza di queste informazioni sono 
>>>>> rigorosamente vietate. Qualora abbiate ricevuto questo documento 
>>>>> per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie.
>>>>>
>>>>> /This e-mail and any attachments// is //confidential and may 
>>>>> contain privileged information intended for the addressee(s) only.
>>>>> Dissemination, copying, printing or use by anybody else is 
>>>>> unauthorised. If you are not the intended recipient, please delete 
>>>>> this message and any attachments and advise the sender by return 
>>>>> e-mail, Thanks./
>>>>>
>>>>> *rispetta l'ambienteRispetta l'ambiente. Non stampare questa mail 
>>>>> se non è
>>>>> necessario.*
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> nice mailing list
>>>>> nice at lists.freedesktop.org
>>>>> http://lists.freedesktop.org/mailman/listinfo/nice
>>>>
>>>>
>>>>
>>>> Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone indicate. La diffusione, copia o qualsiasi altra azione derivante dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate ricevuto questo documento per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie.
>>>>
>>>> This e-mail and any attachments is confidential and may contain privileged information intended for the addressee(s) only. Dissemination, copying, printing or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail, Thanks.
>>>>
>>>> _______________________________________________
>>>> nice mailing list
>>>> nice at lists.freedesktop.org
>>>> http://lists.freedesktop.org/mailman/listinfo/nice
>>>
>>>
>>> _______________________________________________
>>> nice mailing list
>>> nice at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/nice
>>
>>
>> _______________________________________________
>> nice mailing list
>> nice at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/nice
> 
> 
> _______________________________________________
> nice mailing list
> nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice