[Nice] Patch for TURN CreatePermission

Madaro Livio livio.madaro at telecomitalia.it
Fri Nov 2 05:59:21 PDT 2012


Hi, I found a problem using TURN.
Libnice sends a TURN message CreatePermission Request for each remote candidate added by nice_agent_set_remote_candidates. The TURN server replies with a CreatePermission Response and libnice matches the Request and the Response using the message id. The problem is that libnice uses a single variable to store the sent messages (current_create_permission_msg). If a new CreatePermission Request is sent before receiving the Response of the previous one, the variable current_create_permission_msg is overwritten and the Response of the first message will never match the Request.

I send a patch for review. It adds a GList variable (pending_create_permission_messages ) to store all the CreatePermission Request waiting for a Response.

Regards,
Livio

Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone indicate. La diffusione, copia o qualsiasi altra azione derivante dalla conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate ricevuto questo documento per errore siete cortesemente pregati di darne immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie.

This e-mail and any attachments is confidential and may contain privileged information intended for the addressee(s) only. Dissemination, copying, printing or use by anybody else is unauthorised. If you are not the intended recipient, please delete this message and any attachments and advise the sender by return e-mail, Thanks.

[cid:00000000000000000000000000000003 at TI.Disclaimer]Rispetta l'ambiente. Non stampare questa mail se non ? necessario.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/nice/attachments/20121102/3b1f54a7/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Manage-multiple-TURN-CreatePermission-in-parallel.patch
Type: application/octet-stream
Size: 5838 bytes
Desc: 0001-Manage-multiple-TURN-CreatePermission-in-parallel.patch
URL: <http://lists.freedesktop.org/archives/nice/attachments/20121102/3b1f54a7/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: logo Ambiente_foglia2.jpg
Type: image/jpeg
Size: 677 bytes
Desc: logo Ambiente_foglia2.jpg
URL: <http://lists.freedesktop.org/archives/nice/attachments/20121102/3b1f54a7/attachment.jpg>


More information about the nice mailing list