[Nice] Patch for TURN CreatePermission

Youness Alaoui youness.alaoui at collabora.co.uk
Thu Nov 8 10:46:22 PST 2012

Hi Madaro,

Sorry for not replying earlier, I was travelling.
Thanks for the patch. That's a good point you got there, however, the patch kept
the priv->current_create_permission_msg, but I think it should be removed. There
is no reason to keep the message twice (in the list and in the current_*) and it
gets confusing, you do a delete_link and g_free the
current_create_permission_msg in the code, but in the socket_close, you removed
the g_free.. also, you call g_list_free but you should call g_list_free_full in
order to also free the messages contained within the list, otherwise you get a
I don't have time right now to fix all of that myself, could you redo the patch
and send me a new one for review?

Thank you,

On 11/02/2012 08:59 AM, Madaro Livio wrote:
> Hi, I found a problem using TURN.
> Libnice sends a TURN message CreatePermission Request for each remote candidate
> added by nice_agent_set_remote_candidates. The TURN server replies with a
> CreatePermission Response and libnice matches the Request and the Response using
> the message id. The problem is that libnice uses a single variable to store the
> sent messages (current_create_permission_msg).If a new CreatePermission Request
> is sent before receiving the Response of the previous one, the variable
> current_create_permission_msgis overwritten and the Response of the first
> message will never match the Request.
> I send a patch for review. It adds a GList variable
> (pending_create_permission_messages) to store all the CreatePermission Request
> waiting for a Response.
> Regards,
> Livio
> Questo messaggio e i suoi allegati sono indirizzati esclusivamente alle persone
> indicate. La diffusione, copia o qualsiasi altra azione derivante dalla
> conoscenza di queste informazioni sono rigorosamente vietate. Qualora abbiate
> ricevuto questo documento per errore siete cortesemente pregati di darne
> immediata comunicazione al mittente e di provvedere alla sua distruzione, Grazie.
> /This e-mail and any attachments// is //confidential and may contain privileged
> information intended for the addressee(s) only. Dissemination, copying, printing
> or use by anybody else is unauthorised. If you are not the intended recipient,
> please delete this message and any attachments and advise the sender by return
> e-mail, Thanks./
> *rispetta l'ambienteRispetta l'ambiente. Non stampare questa mail se non è
> necessario.*
> _______________________________________________
> nice mailing list
> nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/nice/attachments/20121108/927c5967/attachment.pgp>

More information about the nice mailing list