[Nice] Request for review: MS-TURN TCP transport support

[Youness Alaoui]

Hi Jakub,

Surprising as always! there's a lot of patches in there. I unfortunately don't
have time to review these right now. I had a quick look and there are a couple
of bugs I saw, also, I disagree with the multiplexing of the rtp/rtcp in libnice
(even through that callback function). I think it's better to simply let the
application handle it directly through the recv callback.
Also, the set_stream_transport, I'm not sure at all about that. You will usually
always want a single transport that supports both udp and tcp candidates. You
should have a look at the work-in-progress ice-tcp implementation that George
Kiagiadakis and me did a few months ago :
http://cgit.collabora.com/git/user/gkiagia/libnice.git/log/?h=tcp-so

Basically, the compatibility mode defines whether or not tcp is to be used, and
it applies to all streams. (if you want one udp stream and one tcp stream, then
use two different agents).
This is a much better solution in my opinion and it will also prevent breaking
the API.
I might get some time to review this properly next month.

Thanks!
Youness.


On 11/17/2012 11:01 AM, Jakub Adam wrote:
> Hi,
> 
> I developed a series of libnice patches that enable TCP connection with MS Lync
> media relay servers according to [1], with the initial purpose to enhance A/V
> capabilities of Pidgin Sipe plugin[2].
> 
> Now I'd like to contribute this code to libnice and kindly ask for its review
> first.
> You can fetch it from [3], the actual patches are in branch ms-turn-tcp.
> 
> [1]
> http://download.microsoft.com/download/1/6/F/16F4E321-AA6B-4FA3-8AD3-E94C895A3C97/%5BMS-TURN%5D.pdf
> 
> [2] http://sipe.sourceforge.net
> [3] http://repo.or.cz/w/sipe-libnice.git
> 
> Regards,
> 
> Jakub
> _______________________________________________
> nice mailing list
> nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/nice/attachments/20121119/d679a1bf/attachment.pgp>