[Nice] [PATCH] Bad C preprocessor usage in libnice

[Youness Alaoui]

Hi,
Thanks for noticing!
I've applied the patch and pushed it to the upstream repository.

Thank you,
Youness.

On 09/30/2012 04:54 PM, Askar Safin wrote:
> Hi.
> 
> Libnice has well-known error: it uses C preprocessor wrong. For example, if I type "NICE_CANDIDATE_MAX_FOUNDATION*2", this will be 32+1*2, i. r. 34, not 64. So, please apply the following patch.
> 
> Best regards, Askar Safin
> 
> diff -Naur libnice-ff4a0f5919a22/agent/candidate.h libnice-fixed/agent/candidate.h
> --- libnice-ff4a0f5919a22/agent/candidate.h	2012-09-30 20:44:16.013375097 +0000
> +++ libnice-fixed/agent/candidate.h	2012-09-30 20:47:48.673387867 +0000
> @@ -68,7 +68,7 @@
>   *
>   * The maximum size a candidate foundation can have.
>   */
> -#define NICE_CANDIDATE_MAX_FOUNDATION                32+1
> +#define NICE_CANDIDATE_MAX_FOUNDATION              (32+1)
>  
>  
>  /**
> _______________________________________________
> nice mailing list
> nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice
> 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 259 bytes
Desc: OpenPGP digital signature
URL: <http://lists.freedesktop.org/archives/nice/attachments/20121001/3c9c2344/attachment.pgp>