[Nice] Fw: patch: nice_agent_get_selected_socket

[Bryce Allen]

Patch adds a basic check to test-thread.c. It checks that the return value
is NULL before negotiation is complete, and non-NULL after. Not sure it's
worth trying to make a more elaborate test, what do you think?


On Wed, Nov 20, 2013 at 3:48 PM, Olivier Crête
<olivier.crete at collabora.com>wrote:

> Hi,
>
> I applied your patch, a test would be greatly appreciated.
>
> Olivier
>
> On Sat, 2013-11-16 at 17:17 -0600, Bryce Allen wrote:
> > Forgot to CC the list. I'll work on adding a test too, as Rohan
> > suggested.
> >
> > -Bryce
> >
> >
> > Begin forwarded message:
> >
> > Date: Thu, 14 Nov 2013 16:35:25 -0600
> > From: Bryce Allen <ballen at ci.uchicago.edu>
> > To: Olivier Crête <olivier.crete at collabora.com>
> > Subject: Re: [Nice] patch: nice_agent_get_selected_socket
> >
> >
> > On Thu, 14 Nov 2013 17:10:58 -0500
> > Olivier Crête <olivier.crete at collabora.com> wrote:
> > > I also think returning a GSocket is the right level.
> > >
> > > I think you're not the first one to want this. One question, why do
> > > you just not return a GSocket * or NULL instead of having a separate
> > > boolean and GSocket** ?
> > >
> > I was trying to be consistent with nice_agent_get_selected_pair, but
> > I guess it's using out variables because it needs to return two
> > things. Attached is a modified version that returns GSocket *.
> >
> > Thanks,
> > Bryce
> > _______________________________________________
> > nice mailing list
> > nice at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/nice
>
> --
> Olivier Crête
> olivier.crete at collabora.com
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/nice/attachments/20131125/5eab658e/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: get-selected-socket-test.patch
Type: text/x-patch
Size: 1408 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/nice/attachments/20131125/5eab658e/attachment.bin>