[Nice] Fw: patch: nice_agent_get_selected_socket

[Olivier Crête]

Hi,

I applied your patch, a test would be greatly appreciated.

Olivier

On Sat, 2013-11-16 at 17:17 -0600, Bryce Allen wrote:
> Forgot to CC the list. I'll work on adding a test too, as Rohan
> suggested.
> 
> -Bryce
> 
> 
> Begin forwarded message:
> 
> Date: Thu, 14 Nov 2013 16:35:25 -0600
> From: Bryce Allen <ballen at ci.uchicago.edu>
> To: Olivier Crête <olivier.crete at collabora.com>
> Subject: Re: [Nice] patch: nice_agent_get_selected_socket
> 
> 
> On Thu, 14 Nov 2013 17:10:58 -0500
> Olivier Crête <olivier.crete at collabora.com> wrote:
> > I also think returning a GSocket is the right level.
> > 
> > I think you're not the first one to want this. One question, why do
> > you just not return a GSocket * or NULL instead of having a separate
> > boolean and GSocket** ?
> > 
> I was trying to be consistent with nice_agent_get_selected_pair, but
> I guess it's using out variables because it needs to return two
> things. Attached is a modified version that returns GSocket *.
> 
> Thanks,
> Bryce
> _______________________________________________
> nice mailing list
> nice at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/nice

-- 
Olivier Crête
olivier.crete at collabora.com