[libnice] multithread g_main_loop_quit ad remove agent

Philip Withnall philip at tecnocode.co.uk
Fri Aug 22 00:49:18 PDT 2014


On Sun, 2014-08-10 at 23:40 +0100, Philip Withnall wrote:
> On Thu, 2014-07-24 at 09:02 -0400, Youness Alaoui wrote:
> 
> > Philip, about moving libstun to glib, I prefer not to, there was a lot
> > of work on libstun to make sure it never depends on glib as it's a
> > small lib and we didn't want to bring the glib dependency with it. The
> > thing is that it was Nokia paying for development of libstun a few
> > years ago and they were using it on some of their stuff and "do not
> > depend on glib" was a huge requirement. We may not care anymore but
> > I'd prefer to keep it the way it was designed unless necessary, and I
> > think fixing the ssize_t in win32_common.h is easy to fix and doesn't
> > require to move to glib just yet.
> 
> Patch attached. How about that? It’s completely untested because I don’t
> have access to a Windows build machine at the moment.

Merged to master:

commit 489c8e1c791a172477d0f7ac7a165f4260203cf9
Author: Philip Withnall <philip at tecnocode.co.uk>
Date:   Sun Aug 10 23:38:23 2014 +0100

    stun: Fix definition of ssize_t on Windows
    
    ssize_t should definitely be signed, not unsigned.

 stun/win32_common.h | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)


Philip
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/nice/attachments/20140822/05209c92/attachment.sig>


More information about the nice mailing list