[libnice] Any discussion on API to be able to supply ICE credentials (webrtc related)

Philip Withnall philip at tecnocode.co.uk
Tue Apr 14 03:08:56 PDT 2015


On Wed, 2015-04-08 at 23:19 +0200, Rohan Garg wrote:
> On Tue, Mar 10, 2015 at 3:23 PM, Rohan Garg <rohan16garg at gmail.com> wrote:
> > On Tue, Mar 10, 2015 at 11:23 AM, Philip Withnall
> > <philip at tecnocode.co.uk> wrote:
> >> Rohan: Thanks for the patch. I’ve added some review comments on github
> >> if you would care to take a look at them.
> >>
> >
> > Thanks alot! I'll review and fix them :)
> >
> Sorry it took a while, but here we go [1]

Thanks. I’ve fixed several issues (such as the new API not being in
libnice.sym or libnice.def) and pushed to master.

> Note that if you were using my branch, I've force pushed my changes on
> top, so you'll have to delete your local branch and checkout again.

Note that means (as far as I’m aware), that my original review comments
have been deleted, which makes re-review of the patch trickier.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 213 bytes
Desc: This is a digitally signed message part
URL: <http://lists.freedesktop.org/archives/nice/attachments/20150414/200bbca0/attachment.sig>

More information about the nice mailing list