[libnice] Inquiry re: commit 1ab9d7c104, “conncheck: Separate valid and succeeded states"

[Chad Phillips]

I’m using this WebRTC gateway: https://janus.conf.meetecho.com/

I cannot get latest libnice master to work with this project — ICE hangs in
the ‘connecting' state

Some git bisect work got me to the problem commit:

1ab9d7c104978ea1904aaaad708c1c8c23c77592 is the first bad commit
commit 1ab9d7c104978ea1904aaaad708c1c8c23c77592
Author: Olivier Crête olivier.crete at collabora.com
Date: Thu May 26 16:05:36 2016 -0400

conncheck: Separate valid and succeded states

RFC 5245 specifies that when a mapped-address differs from the address
from the request was sent, the mapped-address is used to select the
valid pair, but the source address of the check is used to select the
pair that succeeded, so they are not the same.

If I roll back this commit, then Janus will work with libnice master,
ICE connections complete fine.

The Janus lead dev looked at that commit, and couldn’t figure out
exactly what it does, or why it would break ICE connectivity when used
with the Janus libnice support code.

I was hoping you could shed some light on:

 - What the added ‘valid’ flag does

 - Where adjustments might be necessary in libnice support code as a
result of this change

Thanks,

Chad
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/nice/attachments/20170227/e27879d3/attachment.html>