[Nouveau] [PATCH 0/4] nvfx: rework render temps code and fixes

[Younes Manton]

On Mon, Jan 16, 2012 at 11:33 AM, Lucas Stach <dev at lynxeye.de> wrote:
> I seems Marek has just accidentally pushed the whole series. So we have
> a bit of a difficult situation here. I'm not sure if we should just
> revert or if we can leave the patches upstream.
>
> I'm aware that this patches haven't received much testing by others than
> me and that a review of the code is still oustanding, but I like to
> stress the point that these patches are rigorously tested by me and are
> relatively low risk.
>
> Patrice your report of this patchset not working did surprise me, so can
> you please make sure those patches are really the cause for your issues?
> I heard reports that nv3x is not working properly with mesa/master for
> some time. I tried to reproduce the problem on my nv49 setup and I don't
> see any issues besides the well known vertex corruption, which is most
> likely due to some missing reloc somewhere or the like.
>
> Regards,
> Lucas
>

This should not have been pushed without at least having been tried on
nv30. You can test every application on earth if you want, but there
are nv30 code paths/limits/behaviours both in userspace and kernel
that you'll never hit running on an nv40, so rigorous testing is
irrelevant in that regard.

Of course the userbase for these cards is dwindling anyway so it's not
a big deal as long as it can be fixed before it gets released.