[Nouveau] [Bug 55412] Screen turns black during boot after driver tries to set mode on NV50

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Nov 8 08:14:06 PST 2012


https://bugs.freedesktop.org/show_bug.cgi?id=55412

--- Comment #4 from m.b.lankhorst at gmail.com ---
Very easy to see what regressed, though..

upstream commit that made it to mainline is c0077061e7ea, with this:

     if (nv_encoder->dcb->lvdsconf.use_acpi_for_edid) {
-        if (!nouveau_acpi_edid(dev, connector)) {
+        if (!(nv_connector->edid = nouveau_acpi_edid(dev, connector))) {
             status = connector_status_connected;
             goto out;
         }

Which looks fine, but is inversion of logic. First it returned 0 on success,
now it returns NULL on failure.. Fix would presumably be one line only:

-        if (!(nv_connector->edid = nouveau_acpi_edid(dev, connector))) {
+        if ((nv_connector->edid = nouveau_acpi_edid(dev, connector))) {

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/nouveau/attachments/20121108/1913fbce/attachment.html>


More information about the Nouveau mailing list