[Nouveau] [Bug 66177] pwm1 value not restored during hibernate/restore cycle in the event of manual fan management mode

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=66177

--- Comment #8 from Martin Peres <martin.peres at ensi-bourges.fr> ---
(In reply to comment #6)
> (In reply to comment #5)
> > Well, I agree that it is my fault that I may not have thought about the
> > suspend/resume cycle. Thanks for reporting that. However, I'm afraid you are
> > hit by another bug, a bug in the ALARM mechanism, which explains why
> > sometimes, the fan speed isn't updated anymore. This is very worrying and
> > may force us to move to using Linux's periodic tasks instead.
> It is indeed a serious bug as the average user may not be as careful as I
> was or may not necessarily pay attention to the card temperature after
> hibernate/restore, particularly if the "auto" fan management was working
> prior to that. If that happens, the video card is almost certain to burn out!

Well, luckily, this isn't true :) PTHERM sends the kernel some IRQs whenever
temperature reaches some threshold. The first one is fan-boost which puts the
fan to 100%. The last one turns off the computer.

This feature shouldn't be affected by resume/suspend.

> 
> > Thanks for this review. I'll work on fixing this ASAP. I can work on the
> > sysfs restoration but I have no card with a PWM fan with me here. I may then
> > require you to test some stuff.
> Have I ever let you down? (;
> 
> When you've made your first call for testing of the therm features over 18
> months ago, I responded and did quite a lot of some testing (you can't deny
> that, can you?), while also benefiting from the "auto" fan management which
> was, at the time, working perfectly. It was simply sublime and was a great
> pity that it didn't make it into the main nouveau repository at the end (I
> used your git thermal fork for absolute ages).

Hey hey, thanks for being supportive. I indeed recognized your nick straight
away.

The new model is nicer than it used to be from a dev point of view. As a user,
I agree the previous system was better. I'll try to improve on that as time
permits :)

> 
> So, I'll be able to help you here with the testing as well, as long as there
> is willingness on your and Ben's part to fix these, in my view, very serious
> bugs.

I agree. I am away from France for a few more months, but I can use my laptop
and fake a fan to check everything is right. I'll see what I can do in a timely
fashion.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/nouveau/attachments/20130628/abe75ece/attachment.html>