[Nouveau] [Bug 73473] Potential crash bug in src/gallium/auxiliary/rtasm/rtasm_execmem.c

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jan 17 15:01:55 PST 2014


https://bugs.freedesktop.org/show_bug.cgi?id=73473

--- Comment #9 from Jaak Ristioja <jaak at ristioja.ee> ---
Personally, I'd keep both the selinux and PaX parts out of the patch.

I suggest simply checking the return value for the mmap call. I think this
would suffice. Keep it simple. There are also other reasons why mmap can fail
(e.g. due to ulimit) and this should be checked. Please fix this first, add
PaX/selinux/whatever support later. :)

PS: While in the selinux patch the selinux code can be conditionally #ifdef
enabled, in the PaX patch the PaX code is not, meaning this results in a minor
performance impact for all users.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/nouveau/attachments/20140117/a9e5d48b/attachment.html>


More information about the Nouveau mailing list