[Nouveau] [Bug 96836] Kernel unaligned access at TPC[105d9fb4] nvkm_instobj_wr32+0x14/0x20 [nouveau]

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=96836

--- Comment #17 from Kieron Gillespie <ciaran.gillespie at gmail.com> ---
(In reply to Ilia Mirkin from comment #15)
> (In reply to Ilia Mirkin from comment #14)
> > OK, well let's start small. One source of problems is that we have
> > 
> > drivers/gpu/drm/nouveau/nouveau_bios.h:#define ROM16(x) le16_to_cpu(*(u16
> > *)&(x))
> > 
> > Which can only work on aligned pointers x, but it gets called with unaligned
> > offsets in nouveau_bios.c
> > 
> > Can you try changing that to
> > 
> > #define ROM16(x) get_unaligned_le16(&(x))
> > 
> > I'm guessing that will help with the first group of unaligned traps.
> 
> Oh, and same treatment for ROM32 of course (and ROM64 while you're at it,
> but that never gets called from what I can tell).

Alright I'll give that a shot and let you know, thanks for the help!

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20160710/0c2494b4/attachment.html>