[Nouveau] [PATCH 0/3] fb fixes for gk20a/gm20b

Alexandre Courbot acourbot at nvidia.com
Thu Oct 27 07:55:51 UTC 2016


After observing random crashes on Tegra devices when patch "fb/gf100: defer DMA
mapping of scratch page to oneinit() hook" was applied, I noticed that moving
the 100c10 page allocation to the oneinit() hook resulted in that page being
now allocated for Tegra as well, and accesses be made to members of gf100_fb
which were not accessible because gk20a_fb_new() called nvkm_fb_new_() directly.

This is fixed by patch 1, but looking at this code made me realize we may just
as well use the regular FB functions for gk20a/gm20b (without the ablity to
allocate VRAM of course), so patches 2 and 3 do that.

Alexandre Courbot (3):
  fb/gk20a: fix constructor call
  fb/gk20a: use regular gf100's functions
  fb: add gm20b device

 drm/nouveau/include/nvkm/subdev/fb.h  |  1 +
 drm/nouveau/nvkm/engine/device/base.c |  2 +-
 drm/nouveau/nvkm/subdev/fb/Kbuild     |  1 +
 drm/nouveau/nvkm/subdev/fb/gf100.h    |  4 ++++
 drm/nouveau/nvkm/subdev/fb/gk20a.c    | 20 ++++++------------
 drm/nouveau/nvkm/subdev/fb/gm200.c    |  2 +-
 drm/nouveau/nvkm/subdev/fb/gm20b.c    | 40 +++++++++++++++++++++++++++++++++++
 7 files changed, 55 insertions(+), 15 deletions(-)
 create mode 100644 drm/nouveau/nvkm/subdev/fb/gm20b.c

-- 
2.10.0



More information about the Nouveau mailing list