[Nouveau] [Bug 111167] Dividing zero by a uniform in loop header causes segfault in nv50_ir::NVC0LegalizeSSA::handleDIV

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jul 18 15:49:27 UTC 2019


https://bugs.freedesktop.org/show_bug.cgi?id=111167

--- Comment #1 from Ilia Mirkin <imirkin at alum.mit.edu> ---
Right...

      Instruction *ld = i->getSrc(s)->getInsn();
      assert(ld->getSrc(0) != NULL);

We must end up propagating the zero imm directly into DIV's args. This is
generally legal even for ops that don't allow imms because of the RZ thing.
However in this case ... it screws things up, since we have to move the value
to a fixed reg.

It looks like the assert() is just misplaced there. It should go into the
"else" clause below and all will be well... we handle the "!ld" / "ld is not a
load/mov" cases already just fine.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20190718/9bc2af27/attachment.html>


More information about the Nouveau mailing list