[Nouveau] [bug report] drm/nouveau/mmu/r535: initial support

Timur Tabi ttabi at nvidia.com
Tue Nov 7 18:17:00 UTC 2023


On Tue, 2023-11-07 at 19:11 +0100, Danilo Krummrich wrote:
I think the problem already starts with gf100_bar_new_() not setting its
pbar argument to NULL on failure, but this code assuming that.

Isn't it standard procedure for functions not to write to output parameters on failure?

Generally, I think it would be better if all those functions would return
an ERR_PTR on failure.

Agreed.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/nouveau/attachments/20231107/f193b19b/attachment-0001.htm>


More information about the Nouveau mailing list