[Ocs] Review Request: Add tests
Frederik Gladhorn
gladhorn at kde.org
Sun Apr 22 13:05:48 PDT 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104692/#review12807
-----------------------------------------------------------
lib/tests/eventtest.cpp
<http://git.reviewboard.kde.org/r/104692/#comment9999>
Did you or Martin write the test?
lib/tests/eventtest.cpp
<http://git.reviewboard.kde.org/r/104692/#comment10000>
Maybe this is not the final state, but how about verifying that the data that was parsed is also right?
- Frederik Gladhorn
On April 22, 2012, 3:38 p.m., Felix Rohrbach wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104692/
> -----------------------------------------------------------
>
> (Updated April 22, 2012, 3:38 p.m.)
>
>
> Review request for Attica and Laszlo Papp.
>
>
> Description
> -------
>
> Add EventTest and MessageTest. Add a list parser test to PersonTest. The data used for the tests is from the specification.
>
>
> Diffs
> -----
>
> lib/tests/CMakeLists.txt 4439d28
> lib/tests/eventtest.cpp PRE-CREATION
> lib/tests/messagetest.cpp PRE-CREATION
> lib/tests/persontest.cpp 6031a05
>
> Diff: http://git.reviewboard.kde.org/r/104692/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Felix Rohrbach
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20120422/aad2e2b1/attachment.htm>
More information about the Ocs
mailing list