[Ocs] Review Request: Add tests

[Felix Rohrbach]

> On April 22, 2012, 8:05 p.m., Frederik Gladhorn wrote:
> > lib/tests/eventtest.cpp, line 4
> > <http://git.reviewboard.kde.org/r/104692/diff/1/?file=58348#file58348line4>
> >
> >     Did you or Martin write the test?

Ups, wrong copy&paste


> On April 22, 2012, 8:05 p.m., Frederik Gladhorn wrote:
> > lib/tests/eventtest.cpp, line 81
> > <http://git.reviewboard.kde.org/r/104692/diff/1/?file=58348#file58348line81>
> >
> >     Maybe this is not the final state, but how about verifying that the data that was parsed is also right?

sounds like a good idea. I just used the existing test as template, and it doesn't check for correct data, too.


- Felix


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104692/#review12807
-----------------------------------------------------------


On April 22, 2012, 3:38 p.m., Felix Rohrbach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104692/
> -----------------------------------------------------------
> 
> (Updated April 22, 2012, 3:38 p.m.)
> 
> 
> Review request for Attica and Laszlo Papp.
> 
> 
> Description
> -------
> 
> Add EventTest and MessageTest. Add a list parser test to PersonTest. The data used for the tests is from the specification.
> 
> 
> Diffs
> -----
> 
>   lib/tests/CMakeLists.txt 4439d28 
>   lib/tests/eventtest.cpp PRE-CREATION 
>   lib/tests/messagetest.cpp PRE-CREATION 
>   lib/tests/persontest.cpp 6031a05 
> 
> Diff: http://git.reviewboard.kde.org/r/104692/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Felix Rohrbach
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20120424/84742dee/attachment.htm>