[Ocs] Review Request: Crashfix for Attica when the network connection is lost after fetching GHNS data.

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105367/#review15317
-----------------------------------------------------------


I would prefer if you did not submit this. First, why are you trying to work on an unrelated method? Backtraces write about the abort method. Second, I would not like to get anything committed in a rush to a stable module without clear logic why the crash is happening, and why the fix would address that.

I am afraid, this might require more investigation from your side.

- Laszlo Papp


On June 26, 2012, 9:04 p.m., Mark Gaiser wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105367/
> -----------------------------------------------------------
> 
> (Updated June 26, 2012, 9:04 p.m.)
> 
> 
> Review request for Attica.
> 
> 
> Description
> -------
> 
> Get hot new stuff could easily crash when filtering the retrieved data. The attached bug report shows a lot of backtraces that gave me a nice starting point in fixing this. I'm not quite sure if i fixed it the proper way. Somehow the original code was emitting the current class pointer followed by removing the same class. I simply removed the remove lines (deleteLayer) since the abort function is also cleaning the stuff up. I hope i'm not introducing a memory leak now?
> 
> 
> This addresses bug 251871.
>     http://bugs.kde.org/show_bug.cgi?id=251871
> 
> 
> Diffs
> -----
> 
>   lib/atticabasejob.cpp c4f0bc8 
> 
> Diff: http://git.reviewboard.kde.org/r/105367/diff/
> 
> 
> Testing
> -------
> 
> Tested it out with the descriptions in the provided bug. It seems to be working just fine now. No more crashes.
> 
> 
> Thanks,
> 
> Mark Gaiser
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20120702/37eb2b71/attachment.html>