[Ocs] Review Request: Comment out some qDebug calls

[Laszlo Papp]

> On June 25, 2012, 1:47 p.m., Frederik Gladhorn wrote:
> > I think Laszlo was working on a similar patch, please check with him. I didn't see how to add people to a review request though.

I was mostly making more professional debug outputs than "Yay.." and so forth. :)

IMO, those outputs are very useful when the library is built in debug mode. If one would not like to see them, they should be able to build release mode, where those are not printed.

What I was actually thinking for the future, is more like loglevels at some point.


- Laszlo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105358/#review15122
-----------------------------------------------------------


On June 25, 2012, 1:34 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105358/
> -----------------------------------------------------------
> 
> (Updated June 25, 2012, 1:34 p.m.)
> 
> 
> Review request for Attica and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> Given that attica is a library, we don't want to flood the user's stdout/stderr with library debug data.
> 
> Comment out the qDebug's, I pondered some of them might be useful in runtime to display the state is not correct. In those cases I changed to qWarning.
> 
> Any opinions?
> 
> 
> Diffs
> -----
> 
>   lib/atticabasejob.cpp c4f0bc8 
>   lib/postfiledata.cpp 5c02976 
>   lib/postjob.cpp 3aed8c9 
>   lib/provider.cpp b7adf0c 
>   lib/providermanager.cpp 5454dbc 
>   lib/putjob.cpp 17b7d51 
>   lib/qtplatformdependent.cpp 8f2a8e6 
> 
> Diff: http://git.reviewboard.kde.org/r/105358/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20120625/0641f81f/attachment.html>