[Ocs] Review Request: Improve libattica dependencies

Felix Rohrbach fxrh at gmx.de
Thu Oct 4 05:28:17 PDT 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106706/#review19883
-----------------------------------------------------------


Why does attica need QtGui? (Note that projecttest is not included in the CMakeLists.txt, so it won't be build)

- Felix Rohrbach


On Oct. 3, 2012, 10:48 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106706/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 10:48 a.m.)
> 
> 
> Review request for Attica.
> 
> 
> Description
> -------
> 
> libattica currently unconditionally depends on QtTest.
> 
> This change simple makes that check dependent on ATTICA_ENABLE_TESTS, as well as adding a missing QtGui check.
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt 49a74ef3448e3e3561950fdc580e0fefe3300ec7 
> 
> Diff: http://git.reviewboard.kde.org/r/106706/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20121004/4bb2f500/attachment.html>


More information about the Ocs mailing list