[Ocs] Review Request: Improve libattica dependencies

[Laszlo Papp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106706/#review19885
-----------------------------------------------------------


Please add me, Felix etc next time to the reviewers as the reviews do not come to the mailing list without subscription and moderation. Unfortunately, we attica maintainers are unable to moderate the list as well, I believe.


lib/CMakeLists.txt
<http://git.reviewboard.kde.org/r/106706/#comment15796>

    Please remove this as:
    
    1) It is only needed for the project test, not globally.
    
    2) It is already added there.
    
    3) It is not Gui what we need, but Widgets.


- Laszlo Papp


On Oct. 3, 2012, 10:48 a.m., Michael Palimaka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106706/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2012, 10:48 a.m.)
> 
> 
> Review request for Attica.
> 
> 
> Description
> -------
> 
> libattica currently unconditionally depends on QtTest.
> 
> This change simple makes that check dependent on ATTICA_ENABLE_TESTS, as well as adding a missing QtGui check.
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt 49a74ef3448e3e3561950fdc580e0fefe3300ec7 
> 
> Diff: http://git.reviewboard.kde.org/r/106706/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Palimaka
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/ocs/attachments/20121004/ef6eb7ce/attachment.html>