[Openchrome-devel] fix typo in alloc check plus possible improvement
Thomas Schlichter
thomas.schlichter
Fri Nov 18 00:09:55 PST 2011
Dear James,
for your latest openchrome changes, I have one fix and one possible
improvement.
1. Changeset 1034 introduced a typo when checking for an unsuccessful
allocation. This is fixed by the attached patch fix_alloc_check.patch.
2. Changeset 1022 changed viaIsOffscreen so it can be used for EXA
PixmapIsOffscreen function. But it did not actually use it for this
purpose. This possible improvement is done by the attached patch
use_viaExaIsOffscreen.patch.
Maybe you've had good reasons not to do 2. If so, I'm quite interested in this
reason... ;-)
Kind regards,
Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_alloc_check.patch
Type: text/x-patch
Size: 492 bytes
Desc: not available
Url : http://wiki.openchrome.org/pipermail/openchrome-devel/attachments/20111118/5398e80b/fix_alloc_check.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: use_viaExaIsOffscreen.patch
Type: text/x-patch
Size: 391 bytes
Desc: not available
Url : http://wiki.openchrome.org/pipermail/openchrome-devel/attachments/20111118/5398e80b/use_viaExaIsOffscreen.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
Url : http://wiki.openchrome.org/pipermail/openchrome-devel/attachments/20111118/5398e80b/attachment.bin
More information about the Openchrome-devel
mailing list