[Openchrome-devel] Fix modeline list generation for tv outputs

[Harry de Boer]

My last patch had a bug that caused the xserver to crash. It took me 
some time to find it as it crashed somewhere else in the xserver (and I 
don't have too much experience with the X code yet...).

The attached patch should fix that. It's a bit different from the 
previous one but I think it's a bit cleaner this way.

Harry

On 27-11-12 23:35, Willem van Asperen wrote:
> On 11/27/2012 11:16 PM, Harry de Boer wrote:
>> About the B & W thing, that does not seem to have anything to do with 
>> the actual colours on the display: it is in my log too but I do have 
>> colour on the TV. Not sure why yours does not, can you send me the 
>> complete log and xorg.conf? Also, what connector are you using? I am 
>> guessing you are using S-Video...
> Correct. It's S-Video. And the TV shows B&W...
> The log is attached.
>>
>> I am getting crashes too btw, I have not looked into that yet.
>>
>> Getting other modes to work is probably going to take some time. It 
>> seems the modelines and tv-register tables [for the VT1625] don't 
>> line up. I already looked a bit into how analogue video and modelines 
>> work but I don't understand all the parts yet.
> You are doing great work; thanks for all your efforts. I would be 
> happy for not having all modes available...
>
> Regards,
> Willem

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/openchrome-devel/attachments/20121206/c013f07b/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-Create-valid-modeline-lists-for-tv-outputs.patch
Type: text/x-patch
Size: 11253 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/openchrome-devel/attachments/20121206/c013f07b/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-VT1625-output-sensing.patch
Type: text/x-patch
Size: 2586 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/openchrome-devel/attachments/20121206/c013f07b/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-VT1625-register-count-is-0x82.patch
Type: text/x-patch
Size: 766 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/openchrome-devel/attachments/20121206/c013f07b/attachment-0002.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-There-is-a-possible-crtc-for-TV-1.patch
Type: text/x-patch
Size: 1401 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/openchrome-devel/attachments/20121206/c013f07b/attachment-0003.bin>