[Openchrome-devel] xf86-video-openchrome: 2 commits - src/via_display.c src/via_lvds.c

Kevin Brace kevinbrace at gmx.com
Fri Apr 22 03:56:47 UTC 2016


Hi Rafał,

> Sent: Wednesday, April 20, 2016 at 5:19 AM
> From: "Rafał Miłecki" <zajec5 at gmail.com>
> To: "Kevin Brace" <kevinbrace at kemper.freedesktop.org>
> Cc: openchrome-devel at lists.freedesktop.org
> Subject: Re: [Openchrome-devel] xf86-video-openchrome: 2 commits - src/via_display.c src/via_lvds.c
>
> Hi
> 
> Can you stop blaming other developers in your commit messages? I find
> it rude. I don't think anyone did any mistakes / poor assumptions on
> purpose.
> 

I do not want to sound mean spirited, but one of the reasons why I am involved in rewriting OpenChrome DDX is due to the fact that it is too buggy, and no one was willing to fix it.
If you have looked at the all the commits I have done over the past 2 1/2 months, many of them are related to code clean up (especially after Version 0.4.0 release).
This happened because the code is in such a mess to the point where it is very difficult to understand what the code is doing in many cases.
Maybe what I will say will hurt your feelings (again, I am not trying to sound mean spirited), but many of the OpenChrome developers have no discipline as device driver developers, and I am the only one cleaning up their mess.
I think I should be thanked for what I am doing.
I think I rightfully earned the right to criticize the past developers from time to time especially if the code is egregiously bad, and this was such case.
I am not throwing out all the code, but there are portions that are really bad, and anything related to standby resume is really bad.
My original reason for getting involved in this project is to fix my VIA hardware laptop's standby resume.
If it was working so well, I probably would not have gotten involved in rewriting OpenChrome.
    Please note that I come from digital hardware design background (RTL coding and verification), and I will like to believe that us hardware engineers take functional correctness far more seriously than people who have never designed hardware (i.e., software people).
While I do not claim to be perfect, I do take pride in the work I do as a hardware guy.

Regards,

Kevin Brace
OpenChrome Project Maintainer


More information about the Openchrome-devel mailing list