[Openchrome-devel] [Bug 96399] New build warnings

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=96399

--- Comment #4 from Xavier Bachelot <xavier at bachelot.org> ---
Hi Kevin,

(In reply to Kevin Brace from comment #3)
> (In reply to Xavier Bachelot from comment #0)
> 
> Hi Xavier,
> 
> > Several build warnings have appeared in the previous months. Here are the
> > relevant extracts of a build log. This is a plain build of the master branch
> > on a fully updated Fedora 23.
> > 
> > via_outputs.c: In function ‘viaProbePinStrapping’:
> > via_outputs.c:1202:17: warning: switch condition has boolean value
> > [-Wswitch-bool]
> >          switch (sr13 && 0xC0) {
> >                  ^
> > 
> 
> I hope the patch I uploaded fixes the compilation warning.
> I hope it fixes the warning.
> 
Yes, the build warning (and bug) is gone.

> 
> > via_ums.c: In function ‘umsCreate’:
> > via_ums.c:711:11: warning: implicit declaration of function
> > ‘xf86InitFBManager’ [-Wimplicit-function-declaration]
> >      ret = xf86InitFBManager(pScreen, &AvailFBArea);
> >            ^
> > via_ums.c:722:9: warning: implicit declaration of function
> > ‘xf86InitFBManagerLinear’ [-Wimplicit-function-declaration]
> >          xf86InitFBManagerLinear(pScreen, offset, size);
> >          ^
> > 
> > I have seen more build warnings when building in a Fedora 23 chroot with the
> > Fedora enforced compile options, which enables more warnings than the plain
> > build. I'll report on them later, once I've taken a deeper look.
> 
> That one I think comes from the code that is used to support XAA.
> When going through EXA code path, OpenChrome does not encounter the above
> API (or ABI or KPI).
> That being said, I do not know if it still has to be there for those
> compiling OpenChrome without the use of EXA or XAA (i.e., xBSD).

I though XAA has been removed from the X server ?
I know precious little about the BSDs, so I can't comment.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/openchrome-devel/attachments/20160613/07072a30/attachment.html>