[openchrome-devel] drm-openchrome: Branch 'drm-next-5.2' - drivers/gpu/drm

[Kevin Brace]

Hi Luc,

As a courtesy, I am letting you know that your name went into openchrome_init.c.

https://cgit.freedesktop.org/openchrome/drm-openchrome/commit/?h=drm-next-5.2&id=92f001d7aa67c79d23d146026c76d13089587c0d

If there are any other concerns you have regarding OpenChrome DDX or DRM, let me know.

Regards,

Kevin Brace
Brace Computer Laboratory blog
https://bracecomputerlab.com


> Sent: Wednesday, March 20, 2019 at 1:51 AM
> From: "Luc Verhaegen" <libv at skynet.be>
> To: "Kevin Brace" <kevinbrace at gmx.com>
> Cc: openchrome-devel at lists.freedesktop.org
> Subject: Re: [openchrome-devel] drm-openchrome: Branch 'drm-next-5.2' - drivers/gpu/drm
>
> On Wed, Mar 20, 2019 at 01:24:19AM +0100, Kevin Brace wrote:
> > Hi Luc,
> >
> > Well, no wonder that portion of the code was relatively clean since the code James did were generally fairly messy.
> > Give me a day or two to examine your portion of the code, but at a first glance, you appear to be correct that he took your code without giving you credit.
> > Generally speaking, I do not rely on your past work, so I only learn about this when you point it out.
> > This is the second time this has happened (first time was the VT1632(A) DVI code, and James committed the buggy code into the repository), and if you wanted to, let me know if there are other portions that other people copied from your past work without attribution.
> > I will use "Suggested-by" to refer to you in the commit message, will this be okay?
>
> _init.c definitely gets my copyright.
>
> Code structure of matching functions is 100% the same, just kernel-ized,
> and my useful comments removed to hide the fact that it was copy pasted.
>
> I do not write many comments, structure speaks for itself, but when i
> do, it is for future reference and it really matters.
>
> Luc Verhaegen.
>