[openchrome-devel] drm-openchrome: Branch 'drm-next-5.2' - drivers/gpu/drm

Luc Verhaegen libv at skynet.be
Mon Mar 25 20:28:56 UTC 2019


On Mon, Mar 25, 2019 at 07:38:12PM +0100, Kevin Brace wrote:
> Hi Luc,
> 
> As a courtesy, I am letting you know that your name went into openchrome_init.c.
> 
> https://cgit.freedesktop.org/openchrome/drm-openchrome/commit/?h=drm-next-5.2&id=92f001d7aa67c79d23d146026c76d13089587c0d
> 
> If there are any other concerns you have regarding OpenChrome DDX or DRM, let me know.

You will find that all chipset detection routines in there are direct 
copies, apart from the vx900, but the latter seems based off of cx700. 
That seems to have been written by Xavier Bachelot.

You will also find that the vram sizing in openchrome_vram_detect() was 
also taken from my via_host.c:ViaFBInit();

The fact that he does << 20 instead of * 1024, or that he sees the need 
to "unify" based on the main detection routines and instead of a 
separate switch statement adds another if in there, does not change the 
fact that this too was taken straight from via_host.c. The double shifts 
are a pretty clear give-away.

James simmons blatantly stole this code on Mon Feb 21 18:44:08 2011 
-0500, with commit c32f8edd2d4c82c5dd877480386a29bab4ed5ac1 as via_fb.c

Here is, once again, the original:
https://cgit.freedesktop.org/~libv/xf86-video-unichrome/tree/src/via_host.c

Some of the code was copied over from via_driver.c, but the below 
commits clearly show the origins of this code:

Commit d06e08595f001d2ded3121aa7912a06df0494286 introduces poking the 
northbridge for ram sizing.

Commit 30120c6fc6ea78b67693039e02df4c382cfda97b expands this ram size 
detection code.

Commit 07da3e6bf255f6d9d4e5f15d2059f5972162b3c1 adds 
VT3205RamControllerGetMemoryClock (km400)

Commit cdc2d63f32c0f33f7d214fdfc74e8c7f5f3f0d6a adds 
VT3108GetMemoryClockFromRamController (k8m800)

Commit df80e3b8033a8fd4f4a6a76fd9740b1fadc7f3f6 adds
VT3122GetMemoryClockFromRamController (cle266)

It is my code, and i spent a metric shitton of time on getting there, 
over all the years listed in my copyright statement. Not just the K8 
code, all but the vx900 code.

Luc Verhaegen.


More information about the openchrome-devel mailing list