[Openchrome-users] XAA SolidFillRect problem with negative x value

[Mark Huijgen]

Benno Schulenberg wrote:
> Mark Huijgen wrote:
>   
>> If I disable this acceleration function with the option
>> Option "XaaNoSolidFillRect"
>> in the Screen section of xorg.conf the glitch is gone.
>>     
>
> This means that the error is in the acceleration function of the 
> driver.  When this function is switched off, calls get passed on to 
> the software rendering functions, which in your case apparently work 
> correctly.
>
> So yes, fault in the driver.
>   
I hacked the function viaSubsequentSolidFillRect a bit to test if it 
also fails to draw if y is negative, but that is not the case. Probably 
viaAccelClippingHelper is used to fix it for negative y's, but nothing 
is done with negative x's.

Is the following code an acceptable fix (placed before the sub=.. 
already there)?

if(x<0) {
         w += x;
         x = 0;
}

sub = viaAccelClippingHelper(cb, y, tdc);

Or do the via chips have a solution like viaAccelClippingHelper?

Regards,
Mark Huijgen