[Openchrome-users] FIX: Re: XAA SolidFillRect problem with negative x value

Benno Schulenberg bensberg
Fri Feb 16 11:01:58 PST 2007


Mark Huijgen wrote:
> After applying this to the viaAccelSolidHelper function:
>
> -    OUT_RING_H1(VIA_REG_DSTPOS, (y << 16) | x);
> +    OUT_RING_H1(VIA_REG_DSTPOS, (y << 16) | (x & 0xFFFF));
>
> The glitch is solved!

Committed in SVN revision 295, plus all other x-es too.

> Since the other via driver from Luc has the same issue, should I
> report this to him too, or do you guys sync these kind of fixes?

Luc follows this list, so he will know by now about the problem.  
But he will probably appreciate it if you send him a proposed patch 
against his code.

> Thanks for the help!

And thank you most of all: for reporting this, and especially for 
testing things and getting to the bottom of it.

Regards,

Benno




More information about the Openchrome-users mailing list