[Openchrome-users] FIX: Re: XAA SolidFillRect problem with negative x value

[Mark Huijgen]

Benno Schulenberg wrote:
> Mark Huijgen wrote:
>> After applying this to the viaAccelSolidHelper function:
>>
>> -    OUT_RING_H1(VIA_REG_DSTPOS, (y << 16) | x);
>> +    OUT_RING_H1(VIA_REG_DSTPOS, (y << 16) | (x & 0xFFFF));
>>
>> The glitch is solved!
> 
> Committed in SVN revision 295, plus all other x-es too.

Verified working on my hardware.

> 
>> Since the other via driver from Luc has the same issue, should I
>> report this to him too, or do you guys sync these kind of fixes?
> 
> Luc follows this list, so he will know by now about the problem.  
> But he will probably appreciate it if you send him a proposed patch 
> against his code.

I just sent him a patch against his source code that fixes all the x's.

Mark