[PATCH] Added p11_kit_module_get_filename()

[Nikos Mavrogiannopoulos]

On Fri, 2015-07-10 at 15:49 +0200, Stef Walter wrote:
> On 10.07.2015 14:43, Nikos Mavrogiannopoulos wrote:
> > I realized that once we load the modules with p11-kit there is no 
> > way
> > back. That is, the software using p11-kit cannot guess which soname 
> > is
> > used for operations. That doesn't matter normally, but that 
> > information
> > is useful to figure for use in non-p11-kit compliant applications.
> > 
> > For example p11tool could list the actual module name of a token to 
> > use
> > with ssh (a non-p11-kit enabled app).
> > 
> > The attached patch adds p11_kit_module_get_filename() to address 
> > that.
> Hmmm callers can use p11_kit_config_option(module, "module") to do 
> this today.

Thanks, that's pretty much what I needed.

> http://p11-glue.freedesktop.org/doc/p11-kit/p11-kit-Modules.html#p11
> -kit-config-option
> 
> But the patch may still make sense as a solid API, however in this 
> case we probably want to return the expanded file name ... the 
> filename is currently expanded in: load_module_from_file_inlock() ... 
> and we should return that expanded name instead.

I've updated the patch to do just that.

regards,
Nikos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Added-p11_kit_module_get_filename.patch
Type: text/x-patch
Size: 5413 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/p11-glue/attachments/20150710/807a7a99/attachment-0001.bin>