[PATCH] Added p11_kit_module_get_filename()

Stef Walter stef-list at thewalter.net
Tue Jul 14 12:32:12 PDT 2015


On 10.07.2015 17:13, Nikos Mavrogiannopoulos wrote:
> On Fri, 2015-07-10 at 15:49 +0200, Stef Walter wrote:
>> On 10.07.2015 14:43, Nikos Mavrogiannopoulos wrote:
>>> I realized that once we load the modules with p11-kit there is no 
>>> way
>>> back. That is, the software using p11-kit cannot guess which soname 
>>> is
>>> used for operations. That doesn't matter normally, but that 
>>> information
>>> is useful to figure for use in non-p11-kit compliant applications.
>>>
>>> For example p11tool could list the actual module name of a token to 
>>> use
>>> with ssh (a non-p11-kit enabled app).
>>>
>>> The attached patch adds p11_kit_module_get_filename() to address 
>>> that.
>> Hmmm callers can use p11_kit_config_option(module, "module") to do 
>> this today.
> 
> Thanks, that's pretty much what I needed.
> 
>> http://p11-glue.freedesktop.org/doc/p11-kit/p11-kit-Modules.html#p11
>> -kit-config-option
>>
>> But the patch may still make sense as a solid API, however in this 
>> case we probably want to return the expanded file name ... the 
>> filename is currently expanded in: load_module_from_file_inlock() ... 
>> and we should return that expanded name instead.
> 
> I've updated the patch to do just that.

Wonderful. Merged.

Stef



More information about the p11-glue mailing list