[packagekit] [PATCH]Service Packs: Creation and Installation

Shishir Goyal crazyontheedge at gmail.com
Fri Aug 8 00:53:24 PDT 2008


> In this case you are leaking 74 bytes of memory. In the first you're
> using g_strconcat() in main() without freeing the result, and in the
> second you are using g_build_filename() in pk_generate_pack_scan_dir().
> Could you fix up these leaks and submit a patch please? Thanks.

Yes, finally i realise how important is it to free the allocated!

I have used g_strjoin instead of g_strconcat now, and have tried to
fix the leaks.

Kindly find the patch attached. Reviews awaited!

Regards
--Shishir
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fix-a-couple-of-memory-leaks-in-pkgenpack.patch
Type: application/octet-stream
Size: 2081 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20080808/77c8d47e/attachment-0004.obj>


More information about the PackageKit mailing list