[packagekit] [PATCH]Service Packs: Creation and Installation
hughsient at gmail.com
Fri Aug 8 01:40:30 PDT 2008
On Fri, 2008-08-08 at 13:23 +0530, Shishir Goyal wrote:
> > In this case you are leaking 74 bytes of memory. In the first you're
> > using g_strconcat() in main() without freeing the result, and in the
> > second you are using g_build_filename() in pk_generate_pack_scan_dir().
> > Could you fix up these leaks and submit a patch please? Thanks.
> Yes, finally i realise how important is it to free the allocated!
> I have used g_strjoin instead of g_strconcat now, and have tried to
> fix the leaks.
> Kindly find the patch attached. Reviews awaited!
I've applied this after changing to g_strjoin (G_DIR_SEPARATOR_S
g_build_filename() -- thanks.
More information about the PackageKit