[packagekit] gpk_animated_icon should skip frame 0

Patryk Zawadzki patrys at pld-linux.org
Fri Apr 3 09:14:48 PDT 2009


Hi,

While i don't think there's a specification for this, animations in
icon themes are supposed to be two-state. The first frame defines what
it looks like in the "stopped" state while the rest of the frames
define the animation. This causes flickering when used with current
gnome-icon-theme where the first frame is completely transparent (sou
you don't get a useless icon every time an application stops
loading/downloading etc.).

I think the proper fix would be to make gpk_animated_icon_update and
gpk_animated_icon_enable_animation skip frame 0 but it would likely
require gpk to adapt its own icons not to assume frame 0 is part of
the animation.

I hope the above is clear ;)

Cheers,

-- 
Patryk Zawadzki



More information about the PackageKit mailing list