[packagekit] PackageKit: pkgenpack fixes

[Richard Hughes]

On Mon, 2009-01-26 at 11:27 +0530, Utsav Handa wrote:
> Hi Richard,
> 
> Many thanks for the encouraging reply.

No problem.

> I have completed adjustments of the code as specified and resending the
> patch.
> Please let me know, if i can help in contributing to PackageKit.

I've committed bits of your patches, refactoring some, and adding fixes
of my own. I've attached the commits that I did for your review.

You'll see that each commit only changes one thing which is the prefered
way to work with git. This allows us to revert or change one tiny part
of the series without pulling the whole lot.

You can also see I tried to reuse as much of the same logic as before --
and moving the logic down from pk_generate_pack_get_filename() into
main. It's easy for me to work out where things best fit as I wrote a
large chunk of the original code, but maybe if you study the patches you
can see the way I worked and broke the problem down into little steps.

Anyway, thanks for your help. Please keep up the good work and sending
patches!

Richard.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-bugfix-don-t-print-an-internal-error-if-we-don-t-pa.patch
Type: text/x-patch
Size: 1137 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20090129/0a24fd97/attachment-0019.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-trivial-export-the-service-pack-filename-in-the-ser.patch
Type: text/x-patch
Size: 1861 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20090129/0a24fd97/attachment-0020.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-trivial-exit-with-the-correct-return-code-in-pkgenp.patch
Type: text/x-patch
Size: 3936 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20090129/0a24fd97/attachment-0021.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-trivial-check-the-user-specified-a-non-zero-length.patch
Type: text/x-patch
Size: 979 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20090129/0a24fd97/attachment-0022.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0005-trivial-check-for-DownloadPackages-in-pkgenpack-as.patch
Type: text/x-patch
Size: 1452 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20090129/0a24fd97/attachment-0023.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0006-feature-allow-the-user-to-specify-a-complete-output.patch
Type: text/x-patch
Size: 1995 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20090129/0a24fd97/attachment-0024.bin>