[packagekit] [PATCH] Qt5 support for PackageKit-qt bindings

[Matthias Klumpp]

2013/7/14 Matthias Klumpp <matthias at tenstral.net>:
> 2013/7/13 Martin Grimme <martin.grimme at gmail.com>:
>> Hi,
>>
>> I fixed the signal connecting and disconnecting stuff for the Qt5
>> build and changed the library name to packagekit-qt5 for the Qt5 build
>> to distinguish it from the Qt4 build.
>>
>> See the attached patch against HEAD.
Regarding the patch: Why do you set the library-name twice? Setting it
once in the root CMakeLists file should be enough. Also, you should
reset SONAME to 0 or 1 for the renamed library, and Daniel needs to
say if the libpackagekit-qt5 naming is okay (next in line would be
libpackagekit-qt3).
I wonder if it would make sense to keep the Qt5 stuff in a separate
branch for now, and then switch to a Qt5-only library as soon as we
can use it in Apper (with the release of KPlatforms5). By doing that,
we would have much less problems, and it would also be less painful
for distribution packagers.
Cheers,
    Matthias