[packagekit] [PATCH] Qt5 support for PackageKit-qt bindings

[Martin Grimme]

Hi,

2013/7/14, Matthias Klumpp <matthias at tenstral.net>:
> Regarding the patch: Why do you set the library-name twice? Setting it
> once in the root CMakeLists file should be enough. Also, you should
> reset SONAME to 0 or 1 for the renamed library, and Daniel needs to
> say if the libpackagekit-qt5 naming is okay (next in line would be
> libpackagekit-qt3).

I've changed my packagekit-qt clone accordingly. See the attached patch.

> I wonder if it would make sense to keep the Qt5 stuff in a separate
> branch for now, and then switch to a Qt5-only library as soon as we
> can use it in Apper (with the release of KPlatforms5). By doing that,
> we would have much less problems, and it would also be less painful
> for distribution packagers.

It would certainly make the build scripts cleaner as the branch would
not have to support building for Qt4 anymore. Makes sense IMHO.
So, shall we proceed in this direction?


Cheers,
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: packagekit-qt5-patch-8ec216b.tgz
Type: application/x-gzip
Size: 6654 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20130723/0f39ef0e/attachment.bin>