[packagekit] Fix show percentage in Katja backend during download

[Sasa Ostrouska]

On Sun, Dec 7, 2014 at 11:25 PM, Sasa Ostrouska <casaxa at gmail.com> wrote:

>
>
> On Sun, Dec 7, 2014 at 10:41 PM, Eugen Wissner <belka.ew at gmail.com> wrote:
>
>> Hi Sasa,
>>
>> Hi Eugene,
>
>
>> in the previous versions I had the problem, that the percentage wasn't
>> reset to 0 after 100%.
>>
>
> I have tested this patch and now the thing is that the percentage is
> showed correctly but of course only for the
> download phase. The percentage on the installing phase is not shown at
> all, but this is another issue i think, it should have nothing to do with
> this one.
>

I have checked a bit the code in the install section, and I believe you
should add also this patch. It still doesnt show the percent progress
during the install phase but looking at the code
this i=0 was in some way forgotten in the for loop. Otherwise it seems
completely wrong as the percent_step * i would be not restarted from 0 but
from where the previous for loop left i value
if Im not understanding it wrong.

Rgds
Saxa


>
>
>> I will test your patch in the next days. By the way PK moved to Github,
>> you can create issues: https://github.com/hughsie/PackageKit/issues
>>
>> I know that now is hosted on github, I sw the announcements on the ML
> some time ago. But I was not aware the way you guys now work on the thing,
> therefore
> I have just used the HACKING file instructions.
>
>
>> Regards
>> Eugene
>>
>> 2014-12-08 1:52 GMT+01:00 Sasa Ostrouska <casaxa at gmail.com>:
>>
>>> Hi, I made a small change to the Katja backend to show the correct
>>> percentage during the downloading of the packages.
>>>
>>> I believe that dividing by 2 the total tasks and have the percentage
>>> shown when downloading up to 50% and when installing the other part from
>>> 50% up to 100% is wrong. IMHO this should show the completing of the task
>>> and not of all the tasks.
>>>
>>> See the attached patch if you want to include it.
>>>
>>> Rgds
>>> Saxa
>>>
>>>
>>>
>>> _______________________________________________
>>> PackageKit mailing list
>>> PackageKit at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/packagekit
>>>
>>>
>>
>> _______________________________________________
>> PackageKit mailing list
>> PackageKit at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/packagekit
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20141207/77190ac9/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Added-the-init-of-i-into-the-installing-loop.patch
Type: text/x-patch
Size: 1019 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/packagekit/attachments/20141207/77190ac9/attachment-0001.bin>